Disable FLoC #1536
Merged
Disable FLoC #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a really good idea. I noticed FLoC is already in the currently available Chromium version from https://download-chromium.appspot.com/. It's a setting called 'Privacy Sandbox'. |
|
Thank you so much @Ahrotahn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables Federated Learning of Cohorts (FLoC) functionality. Currently FLoC is enabled through an origin trial and is expected to be implemented next month.
The change in
floc_id_provider_factory.ccis the most significant at this point.The other two changes aren't used extensively yet but will matter more in the future as FLoC is updated. There are already new commits on the main branch that make further use of
IsFlocAllowed()and most of the checks onkInterestCohortAPIOriginTrialwill likely be updated to checkkFederatedLearningOfCohorts.Resolves #1474